Re: PATCH: prettyprinter and colors

[Ilya Zakharevich <ilya@math.ohio-state.edu>]

On Fri, Sep 22, 2000 at 08:15:42PM -0400, Ilya Zakharevich wrote:
> a) introduces two new options to default(color) command: "lightbg" and
>    "darkbg", and removes the "yes" option (does not make a lot of
>    sense if you do not know the background).
> 
> 	 default(colors,l)
> 
>    The only tune up I did was for the contrast of the most significant
>    parts of the output.  Also: darkbg is not tuned up for contrast yet.

I checked, and the following gives much better results wrt contrast on
black background both on a PC console, and on a correctly configured
color xterm (do not have unconfigured one, so cannot be sure ;-).

--- ./src/gp/gp.c-pre	Thu Sep 28 15:30:47 2000
+++ ./src/gp/gp.c	Thu Sep 28 15:31:48 2000
@@ -527,7 +527,7 @@ sd_colors(char *v, int flag)
     if (l <= 2 && strncmp(v, "no", l) == 0)
       v = "";
     if (l <= 6 && strncmp(v, "darkbg", l) == 0)
-      v = "1, 5, 3, 7, 6, 2, 3";	/* Assume recent ReadLine. */
+      v = "[1,,1], [5,,1], [3,,1], [7,,1], [6,,1], [2,,1], [3,,1]";	/* Assume recent ReadLine. */
     if (l <= 7 && strncmp(v, "lightbg", l) == 0)
       v = "1, 6, 3, 4, 5, 2, 3";	/* Assume recent ReadLine. */
     tmp = v = pari_strdup(v); filtre(v, f_INIT|f_REG);


FYI: my xtermc is configured to have high-bit-set colors (8..15) to be
brighter than the corresponding colors (0..7), and I think I also
asked for the translation of bold to color.  (Do not remember the
details, but probably it is more or less default behaviour.)

Enjoy,
Ilya